Archive for March 21st, 2009

Mails after committing files with issues

Last evening David Faure and me made some changes to the post commit hook. Normally commits can be followed via the kde-commits mailinglist. After our change it will also sent a mail to the committer if there is a problem with a commit.

As the project gets more contributors and more commits, the percentage of committers which are subscribed to the kde-commits mailinglist will decrease. No, I’m not the one who have done actual research into that, i’ll leave that to the experts, I just like random guesses. Anyhow, we felt that committers were more and more unaware of problems with their commits. I think someone (was it Cornelius?) pointed me to that issue at the last pim-meeting.

So, whenever you commit a file without a license, with an unknown license, with security issues, utf-problems or some syntax error, you will get a cc of your commit. Just make sure your e-mail address is up-to-date in kde-common/accounts. Also, it can lead to some duplicate messages if you are also subscribed to the commits via commitfilter.kde.org. Not much we can do about that.

I hope it’s another little improvement for people, so that they aware of a problem in their commit and that way improve overall quality of the files in svn.